Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deviceCredentialFallback default value #1098

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Added deviceCredentialFallback default value #1098

merged 3 commits into from
Mar 18, 2025
+14 −10

Conversation

subhankarmaiti
Copy link
Contributor

@subhankarmaiti subhankarmaiti commented Mar 11, 2025 •
edited
Loading

Changes

  • Updated the deviceCredentialFallback property within the LocalAuthenticationOptions interface to default to false.
  • Revised the SDK documentation to reflect the new default value of the deviceCredentialFallback property.

References

  • GitHub Issue: #980

Checklist

Sorry, something went wrong.

@subhankarmaiti subhankarmaiti requested a review from a team as a code owner March 11, 2025 15:04
pmathew92
pmathew92 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@pmathew92 pmathew92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subhankarmaiti subhankarmaiti merged commit 2b9c633 into master Mar 18, 2025
4 checks passed
@subhankarmaiti subhankarmaiti deleted the bugfix/980-device-credential-fallback branch March 18, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailash-b kailash-b

@pmathew92 pmathew92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@subhankarmaiti @kailash-b @pmathew92