Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-85: Adding deprecation warnings for certain exclusion properties #481

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Apr 6, 2022

✏️ Changes

As mentioned in #451 , the Deploy CLI is positioning itself as the de facto bulk configuration management tool for Auth0. This is in contrast to the Auth0 Terraform Provider which is much more oriented towards more granular, bespoke configurations on an asset-by-asset basis. These positioning are intentional and indicative of the general visions for each tool.

Part of this positioning is deprecation of exclusion properties that target by an asset's ID. Specifically:

  • AUTH0_EXCLUDED_RULES
  • AUTH0_EXCLUDED_CLIENTS
  • AUTH0_EXCLUDED_DATABASES
  • AUTH0_EXCLUDED_CONNECTIONS
  • AUTH0_EXCLUDED_RESOURCE_SERVERS
  • AUTH0_EXCLUDED_DEFAULTS

This PR adds warnings about the usage of these parameters are deprecated and are subject to removal in future major versions.

🔗 References

🎯 Testing

Adds test cases that spy on the logger and detects the presence and absence of the deprecation warnings appropriately.

@willvedd willvedd requested a review from a team as a code owner April 6, 2022 22:18
@willvedd willvedd merged commit f4f3e0f into master Apr 7, 2022
@willvedd willvedd deleted the DXCDT-85-deprecation-warnings-bespoke-exclusion branch April 7, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants