Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensibility as custom phone provider deploy cli support #1038

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Extensibility as custom phone provider deploy cli support #1038

wants to merge 3 commits into from

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Feb 27, 2025 •
edited
Loading 

phoneProviders:
  - name: twilio
    configuration:
      sid:sample_sid
      default_from: ++15673812244
      delivery_methods:
        - text
        - voice
    disabled: false

🔧 Changes

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

kushalshit27
kushalshit27 reviewed Feb 27, 2025
View reviewed changes
src/context/directory/handlers/phoneProvider.ts Outdated
fs.ensureDirSync(phoneProvidersFolder);

const phoneProviderFile = path.join(phoneProvidersFolder, 'provider.json');
// @ts-ignore
Copy link
Contributor

@kushalshit27 kushalshit27 Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using @ts-ignore?

kushalshit27
kushalshit27 reviewed Feb 27, 2025
View reviewed changes
src/context/defaults.ts
@@ -52,3 +52,21 @@ export function emailProviderDefaults(emailProvider) {

return updated;
}

export function phoneProviderDefaults(phoneProvider) {
// eslint-disable-line
Copy link
Contributor

@kushalshit27 kushalshit27 Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using @ts-ignore?

kushalshit27
kushalshit27 requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pr checks failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalshit27 kushalshit27 kushalshit27 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramya18101 @kushalshit27