Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new ACUL screens in PROMPT_SCREEN_MAPPINGS List #1035

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Feb 21, 2025

🔧 Changes

Support new screens on ACUL as part of release-3:

Prompt-name Screen-name
mfa mfa-detect-browser-capabilities
mfa mfa-enroll-result
mfa mfa-begin-enroll-options
mfa-sms mfa-country-codes
mfa-email mfa-email-challenge
mfa-email mfa-email-list
mfa mfa-login-options
mfa-push mfa-push-challenge-push
mfa-push mfa-push-enrollment-qr
mfa-push mfa-push-list
mfa-push mfa-push-welcome
mfa-sms mfa-sms-challenge
mfa-sms mfa-sms-enrollment
mfa-sms mfa-sms-list

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101 ramya18101 requested a review from a team as a code owner February 21, 2025 08:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (cf60453) to head (fed30ca).

Files with missing lines Patch % Lines
src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files         125      125           
  Lines        4595     4595           
  Branches      898      898           
=======================================
  Hits         3683     3683           
  Misses        541      541           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya18101 ramya18101 merged commit f632de7 into master Feb 21, 2025
8 checks passed
@ramya18101 ramya18101 deleted the DXCDT-894-Support-release-3-ACUL-screens-on-CDT branch February 21, 2025 09:20
@ramya18101 ramya18101 mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants