Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyword preservation for clientGrants handling #1032

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Feb 14, 2025

🔧 Changes

fix: keyword preservation for client grant handling

Example:

clientGrants:
    - client_id: Test Application
      audience: '##API_IDENTIFIER##'
      scope: '@@API_EXPLORER_APPLICATION_CLIENT_GRANT_SCOPES@@'

⚙ config:

 "AUTH0_INCLUDED_ONLY": [ "clients", "clientGrants"]

📚 References

🔬 Testing

  • Test added

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 changed the title fix: keyword preservation for client grant handling fix: keyword preservation for clientGrants handling Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (900c4a5) to head (cebcdbe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   80.11%   80.15%   +0.03%     
==========================================
  Files         125      125              
  Lines        4586     4595       +9     
  Branches      896      898       +2     
==========================================
+ Hits         3674     3683       +9     
  Misses        541      541              
  Partials      371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review February 17, 2025 05:40
@kushalshit27 kushalshit27 requested a review from a team as a code owner February 17, 2025 05:40
@kushalshit27 kushalshit27 merged commit ae2849f into master Feb 19, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-856-fix-keyword-preservation-client-grants branch February 19, 2025 14:48
@ramya18101 ramya18101 mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants