Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve single card view #172

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Improve single card view #172

merged 2 commits into from
Jul 6, 2020

Conversation

austinpray
Copy link
Owner

@austinpray austinpray commented Jul 5, 2020

Split from #170


Single card view now looks like this:

image

before

image

@austinpray austinpray requested a review from ridhoq July 5, 2020 22:46
@pull-request-size pull-request-size bot added the size/M Denotes a Pull Request that changes 30-99 lines label Jul 5, 2020
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #172 into master will increase coverage by 0.07%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   75.02%   75.10%   +0.07%     
==========================================
  Files          67       67              
  Lines        1914     1928      +14     
  Branches      268      272       +4     
==========================================
+ Hits         1436     1448      +12     
- Misses        399      400       +1     
- Partials       79       80       +1     
Impacted Files Coverage Δ
kaori/plugins/gacha/commands/display.py 51.35% <0.00%> (ø)
kaori/plugins/gacha/models/Card.py 91.80% <100.00%> (-1.31%) ⬇️
kaori/plugins/gacha/tui.py 98.14% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c588bf1...9f9596e. Read the comment docs.

@austinpray austinpray merged commit c93440f into master Jul 6, 2020
@austinpray austinpray deleted the better-display branch July 6, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/gacha size/M Denotes a Pull Request that changes 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant