feat: add target recalculation functionality and UI controls for saving and resetting targets #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

MattG57 wants to merge 1 commit into main from targeting-bugfixes

Collaborator

MattG57 commented Jun 15, 2025

Also, fixed time savings chart to use configured targets & max values


          feat: add target recalculation functionality and UI controls for savi…

…ng and resetting targets

Also, fixed time savings chart to use configured targets & max values

github-actions bot commented Jun 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-advanced-security bot found potential problems

View reviewed changes

backend/src/services/target-calculation-service.ts

    
                    const totalPercent = userSurveys.reduce((sum, survey) => {

                      const percentTimeSaved = typeof survey.percentTimeSaved === 'number' ? survey.percentTimeSaved : 0;

                      // Always parse percentTimeSaved as float

                      const percentTimeSaved = survey.percentTimeSaved != null ? parseFloat(survey.percentTimeSaved as any) : 0;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;

                  const percentCoding = typeof this.settings.percentCoding === 'number' ? this.settings.percentCoding : 50;

                  // Convert settings values to numbers (parse from string if needed)

                  const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  const percentCoding = typeof this.settings.percentCoding === 'number' ? this.settings.percentCoding : 50;

                  // Convert settings values to numbers (parse from string if needed)

                  const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;

                  const percentCoding = this.settings.percentCoding != null ? parseFloat(this.settings.percentCoding as any) : 50;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  // Calculate max based on settings

                  const maxPercentTimeSaved = typeof this.settings.percentTimeSaved === 'number' ? this.settings.percentTimeSaved : 20;

                  const maxPercentTimeSaved = this.settings.percentTimeSaved != null ? parseFloat(this.settings.percentTimeSaved as any) : 20;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  // Ensure all values are properly typed as numbers

                  const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;

                  // Always parse settings values as numbers (from string if needed)

                  const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  const weeksInYear = Math.round(hoursPerYear / 40) || 50; // Calculate weeks and ensure it's a number

                  const devCostPerYear = typeof this.settings.devCostPerYear === 'number' ? this.settings.devCostPerYear : 0;

                  const devCostPerYear = this.settings.devCostPerYear != null ? parseFloat(this.settings.devCostPerYear as any) : 0;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

backend/src/services/target-calculation-service.ts

    
                  // Convert hours per year to number

                  const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;

                  // Always parse hours per year as number

                  const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

github-advanced-security bot found potential problems

View reviewed changes

frontend/src/app/main/copilot/copilot-value-modeling/copilot-value-modeling.component.ts

    
                resetTargets() {

                  // Call the backend endpoint to recalculate targets

                  this.targetsService.recalculateTargets().subscribe((result: any) => {

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

frontend/src/app/services/api/targets.service.ts

    
                recalculateTargets() {

                  // Calls the backend endpoint to recalculate targets

                  return this.http.get<any>(`${this.apiUrl}/calculate`);

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet