Repository navigation
Conversation
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
catacomb::read() mapped every failure to None, which the enrollment, restore, deletion and owner-probe paths read as "no saved catacomb". Return Result<Option<_>> so that only a missing file reads as absent, add is_saved()/is_absent() for the callers, and make read_stored() propagate read errors so restore reports Failed rather than NoStoredFile. Test both callers that run on these paths: restore_catacomb() must fail without contacting the enclave on an unreadable catacomb or host store, and the owner probe must stop before its enclave check when the owner or master file cannot be read. Drop a source-text assertion made redundant by the native boundary test. Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
…port-234-20261104
…port-234-20261104
Member
Author
|
@DjDeveloperr @RyanTheTide ready for your regression testing. It hasn't been boot-tested on J613 with 7.3 yet; I'll post the result here when I have it. |
Member
Author
|
J613 boot result on 7.3 (rubra, M3 MacBook Air 13", macOS 26.6.2 / 25G83 firmware), 2026-11-05.
|
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refuse unreadable and partial saved SEP identities instead of treating them as absent. Preserve Aurora’s newer orphan recovery and enrol preparation; no storage format or enclave protocol changes.
Port of omacom/linux-aurora#234. The original PR remains untouched.
Validation: arm64 defconfig + asahi.config, Image/modules/DTBs with BTF and KUnit enabled, LLVM 18/Rust 1.85.0, passed at stack top #345 (
2565987465a2), which includes this branch. The validated integration base is b500668. QEMU loaded the test-bearing modules successfully with no additional failures. The combined run retains four pre-existing SEP store failures (plus their suite aggregate), reproduced on the unmodified Aurora base. The unmodified pinned base also crashes in apple-av-audio-lifetime/av_lifetime_devres_order; that unrelated audio suite is explicitly excluded. All tests added by these ports run through KUnit debugfs on Cortex-A76. This is not a fully green or complete-tree KUnit run. Store-open and identity/caller fixtures passed normally and with optimized Python. No 7.3 hardware boot or deployment has been performed.