Skip to content

Remove API url columns (that can be recalculated) from the contributors table #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MoralCode wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove API url columns (that can be recalculated) from the contributors table #3747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b54cbb
remove url fields that can be recreated later
MoralCode Mar 2, 2026
f3db49a
add comments to remaining URLs to document why they are kept around d…
MoralCode Mar 2, 2026
1fed855
generate data migration for this change
MoralCode Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions augur/application/db/models/augur_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,20 +218,17 @@ class Contributor(Base):
String,
comment="populated with the github user name for github originated data. ",
)
gh_url = Column(String)
gh_html_url = Column(String)
gh_url = Column(
String,
comment="Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future."
)
gh_html_url = Column(
String,
comment="Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future."
)
gh_node_id = Column(String)
gh_avatar_url = Column(String)
gh_gravatar_id = Column(String)
gh_followers_url = Column(String)
gh_following_url = Column(String)
gh_gists_url = Column(String)
gh_starred_url = Column(String)
gh_subscriptions_url = Column(String)
gh_organizations_url = Column(String)
gh_repos_url = Column(String)
gh_events_url = Column(String)
gh_received_events_url = Column(String)
gh_type = Column(String)
gh_site_admin = Column(String)
gl_web_url = Column(
Expand Down
66 changes: 66 additions & 0 deletions augur/application/schema/alembic/versions/39_remove_unused_api_url_fields_in_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
"""remove unused api url fields in contributors table

Revision ID: 39
Revises: 38
Create Date: 2026-03-02 15:49:34.325165

"""
from alembic import op
import sqlalchemy as sa


# revision identifiers, used by Alembic.
revision = '39'
down_revision = '38'
branch_labels = None
depends_on = None


def upgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.alter_column('contributors', 'gh_url',
existing_type=sa.VARCHAR(),
comment='Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future.',
existing_nullable=True,
schema='augur_data')
op.alter_column('contributors', 'gh_html_url',
existing_type=sa.VARCHAR(),
comment='Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future.',
existing_nullable=True,
schema='augur_data')
op.drop_column('contributors', 'gh_starred_url', schema='augur_data')
op.drop_column('contributors', 'gh_organizations_url', schema='augur_data')
op.drop_column('contributors', 'gh_repos_url', schema='augur_data')
op.drop_column('contributors', 'gh_followers_url', schema='augur_data')
op.drop_column('contributors', 'gh_subscriptions_url', schema='augur_data')
op.drop_column('contributors', 'gh_received_events_url', schema='augur_data')
op.drop_column('contributors', 'gh_gists_url', schema='augur_data')
op.drop_column('contributors', 'gh_following_url', schema='augur_data')
op.drop_column('contributors', 'gh_events_url', schema='augur_data')
# ### end Alembic commands ###


def downgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.add_column('contributors', sa.Column('gh_events_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_following_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_gists_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_received_events_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_subscriptions_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_followers_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_repos_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_organizations_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.add_column('contributors', sa.Column('gh_starred_url', sa.VARCHAR(), autoincrement=False, nullable=True), schema='augur_data')
op.alter_column('contributors', 'gh_html_url',
existing_type=sa.VARCHAR(),
comment=None,
existing_comment='Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future.',
existing_nullable=True,
schema='augur_data')
op.alter_column('contributors', 'gh_url',
existing_type=sa.VARCHAR(),
comment=None,
existing_comment='Convenience url to aid in manually debugging database and sanity checking against GitHub API results (tools like dbeaver make links like this clickable). May be removed in the future.',
existing_nullable=True,
schema='augur_data')
# ### end Alembic commands ###
Loading