Skip to content

lint: remove invalid type annotation in repo_load_controller #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhaneshKolu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lint: remove invalid type annotation in repo_load_controller #3745

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df58d37
lint: remove invalid type annotation for directive in repo_load_contr…
Feb 28, 2026
a4eed2b
lint: remove invalid type annotation for directive in repo_load_contr…
DhaneshKolu Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion augur/util/repo_load_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def get_colum_by_label(label: str)-> Column:
return None, {"status": "Invalid order by"}

# Find the column named in the 'order_by', and get its asc() or desc() method
directive: function = getattr(get_colum_by_label(order_by), direction.lower())
directive: getattr(get_colum_by_label(order_by), direction.lower())
Copy link
Copy Markdown
Collaborator

@shlokgilda shlokgilda Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the bogus ":" from the code.

Suggested change
directive: getattr(get_colum_by_label(order_by), direction.lower())
directive = getattr(get_colum_by_label(order_by), direction.lower())

Copy link
Copy Markdown
Contributor Author

@DhaneshKolu DhaneshKolu Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thanks for pointing out


repos = repos.order_by(directive())

Expand Down
Loading