Set HOME variable in containers to avoid a permissions error when git persists configuration#3559
Conversation
guptapratykshh
force-pushed
the
fix/docker-startup-race-condition
branch
2 times, most recently
from
dc95d67 to
91d0576
Compare
guptapratykshh
changed the title
docker-compose.yml
Outdated
| networks: | ||
| - augur | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "pg_isready -U ${AUGUR_DB_USER:-augur} -d augur"] |
There was a problem hiding this comment.
is there an environment variable that allows the value of the database augur uses to be configured? if so we should use that for the -d argument
There was a problem hiding this comment.
this is the one have added there also- AUGUR_DB_NAME:-augur
| - redis | ||
| - augur-keyman | ||
| - rabbitmq |
There was a problem hiding this comment.
I think one of the other PRs for this also had changes to these lines to specifiy that they could start as long as the DB was up (before it becomes healthy).
is that the default behavior?
There was a problem hiding this comment.
Yes, service_started is default behavior when no condition is specified. I have updated docker-compose.yml
to explicitly state condition: service_started for Redis, Keyman, and RabbitMQ to avoid any ambiguity, while keeping the strict service_healthy check for the database to prevent race condition.
guptapratykshh
force-pushed
the
fix/docker-startup-race-condition
branch
from
91d0576 to
06a58a2
Compare
MoralCode
added
the
redundant
|
Superseded by #3613 |
|
This doesnt solve the linked issue by itself, but still may be important to merge |
|
Hello! Just wanted to check in to see if you were still interested in helping the maintainers merge this PR. We noticed it has been a little while since this last had activity, and are considering closing it or taking it over if it remains in its current state. Please react to or reply to this to confirm your interest in the next 7 days or let us know if you are no longer interested in this so we can best prioritize everyone's contributions. Thanks! |
MoralCode
added
the
stale
Signed-off-by: guptapratykshh <[email protected]>
MoralCode
force-pushed
the
fix/docker-startup-race-condition
branch
from
56645df to
0468a53
Compare
|
Im taking over and repurposing this issue to just contain the HOME fix because the rest of the fix is already present in #3613 |
MoralCode
added
containers
MoralCode
changed the title
MoralCode
changed the title
|
@ABrain7710 Could this complement your work on facade credentials? I think this particular issue relates to the creation of .gitconfig, which i think git defaults to using the homedir for. maybe we should redirect this to the config dir to persist it? |
|
https://stackoverflow.com/a/6172338 (symlinking) may also be a potential option. Part of the issue is that our custom user in docker land doesnt have their own homedir. |
2 participants
Description
this solves docker startup race conditions by adding a database health check and setting HOME=/tmp for handling permissions.
Notes for Reviewers
Signed commits