Skip to content

Pass db_session to user delete method #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptapratykshh wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

Pass db_session to user delete method #3509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b31ac
Fix #2672: Pass db_session to user delete method
guptapratykshh Jan 9, 2026
c97f765
Revert original fix in 18b31ac1eaf529ee9d76a2f41ba473d43cf5e552
MoralCode Mar 16, 2026
0da33d7
start simple
MoralCode Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion augur/api/view/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,11 @@
@app.route('/account/delete')
Copy link
Copy Markdown
Collaborator

@shlokgilda shlokgilda Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from this PR, but user_delete is on a GET route. Might be worth a follow-up to change this to POST.

@login_required
def user_delete():
if current_user.delete()[0]:
if current_user.delete(db_session)[0]:
flash(f"Account {current_user.login_name} successfully removed")
logout_user()
else:
logger.error(f"Exception occurred while deleting account {current_user.login_name}: {e}")

Check warning on line 205 in augur/api/view/routes.py

View workflow job for this annotation

GitHub Actions / runner / pylint 

[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'e' (undefined-variable)

Raw Output:
augur/api/view/routes.py:205:93: E0602: Undefined variable 'e' (undefined-variable)
Copy link
Copy Markdown
Collaborator

@shlokgilda shlokgilda Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no try/except (e will be undefined). Either wrap the delete in a try/except or just drop the logger line.

Copy link
Copy Markdown
Collaborator

@shlokgilda shlokgilda Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current_user.login_name might not be valid after delete() since it commits the row deletion internally. Capture the username before calling delete.

flash("An error occurred removing the account")

return redirect(url_for("root"))
Expand Down
Loading