Conversation
There was a problem hiding this comment.
Solid addition of rules and MCP config support, and the instruction flag handling fix looks good. I left one small, high‑confidence suggestion to improve observability. Also, consider adding unit tests that cover the new inputs’ validation and CLI argument forwarding paths.
🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.
src/index.ts
Outdated
| } | ||
| args.push(instruction_value); | ||
|
|
||
| if (inputs.rules?.length) { |
There was a problem hiding this comment.
Minor observability suggestion: it could help troubleshooting to log how many rules and MCP config paths were provided before invoking auggie, and optionally de‑duplicate the arrays to avoid passing duplicate flags. For example:
Current code:
if (inputs.rules?.length) {
for (const rulePath of inputs.rules) {
args.push('--rules', rulePath);
}
}
if (inputs.mcpConfigs?.length) {
for (const configPath of inputs.mcpConfigs) {
args.push('--mcp-config', configPath);
}
}Suggested improvement:
const uniqueRules = Array.from(new Set(inputs.rules ?? []));
const uniqueMcp = Array.from(new Set(inputs.mcpConfigs ?? []));
if (uniqueRules.length) {
logger.info(`🔧 Applying ${uniqueRules.length} rule file(s)`);
for (const rulePath of uniqueRules) args.push('--rules', rulePath);
}
if (uniqueMcp.length) {
logger.info(`🧩 Applying ${uniqueMcp.length} MCP config file(s)`);
for (const cfg of uniqueMcp) args.push('--mcp-config', cfg);
}There was a problem hiding this comment.
The additions for rules and mcp_configs are threaded end-to-end (action inputs, env wiring, validation, and CLI flags) and the argument construction for instructions has been corrected. Validation behavior for JSON array inputs looks robust, including empty and malformed cases. Review completed. No suggestions at this time.
Add support for rules and MCP configs to the GitHub Action
rulesandmcp_configsinaction.yml; each expects a JSON array of file pathsauggieas--rules <path>and each MCP config path as--mcp-config <path>ActionInputsandINPUT_FIELD_MAPto includerulesandmcpConfigsWhy
Compatibility
Examples
🤖 This description was generated automatically. Please react with 👍 if it's helpful or 👎 if it needs improvement.