-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General update itsybitsy m0 #559
General update itsybitsy m0 #559
Conversation
… the differences which are relevant for the Itsybitsy M0 HW. Also existing examples have been adjusted to build
… in feather m0 board, with minor required changes
…e feather m0 board, with minor required changes. Other fixes in the spi examples as well
If this is mostly just a copy and rework of |
That's right @bradleyharden, this is a copy and rework of |
@javiser, I just confirmed that the pin/sercom definitions are correct to the hardware. |
Ok, @jbeaurivage, I finally found some time and resynchronized everything with the current master. I still would like to hook up the board and do a couple of basic tests to see if the things are working yet fine, but in the mean time, if you are interested, you can finish the review. We will also need to decide what to do with the above open tasks. Either somebody helps me there with that or we need to "merge at risk and hope for the best". |
Thanks @javiser. I'm pretty confident the I think you'll have a hard time finding someone here with both an itsybitsy m0 and an ssd1306 to test. Overall I'm comfortable merging whenever you complete your tests. |
So I finally managed to flash some of the tests, but none of the ones with external periphery and I could not test any of the tests I requested help for anyways. Based on your previous comment, I have decided to remove the corresponding tasks. I think that this PR can be merged now, it is up to you now @jbeaurivage . Thanks again for your help! |
Thanks! |
Summary
The goal of this PR is to bring the ItsyBitsy M0 (which is a Tier 2 BSP) to the same "maturity" level of a Tier 1 BSP. Instead of just bumping a couple of dependencies as done with other boards (i.e. for the ItsyBitsy M4 in #547, which by the way was quite useful as reference for this PR), my proposal is to take advantage of the fact that the ItsyBitsy M0 is internally pretty similar to the Feather M0, which is Tier 1. So I copied the current code of the Feather M0 and made the changes necessary to reflect the HW differences. I also copied the examples from the Feather M0 and adjusted them as necessary, and kept the existing examples where necessary or meaningful. By doing do I hope that maintaining this board as Tier 2 BSP will much easier, as keeping an eye on the Feather M0 and implementing deltas will be much easier. The main and relevant differences between the boards are:
What has been done in this PR:
💡 Hint: It might be useful to compare the contents of the
feather_m0
folder with this new version ofitsybitsy_m0
as well, as this might show the changes of this PR better than the before-after comparison of theitsybitsy_m0
files.What should be done yet:
Somebody help me test all ssd1306 examples with a real displaySomebody help me test the newadc.rs
,clock.rs
,dmac.rs
anduart.rs
examples copied fromfeather_m0
(even if I am pretty sure that they should work just as fine as for the Feather M0)Checklist
CHANGELOG.md
for the BSP or HAL updated