-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SPI Error support defmt::Format #522
Conversation
Can we do this for |
#467 will unify the implementation for the different chips, so that won't be an issue anymore. It might make sense to merge that one, since it's ready, and apply this PR to the new code. |
Sure, I'll rebase when that is merged.
Let's keep this to SPI for now (since that is what I need), we can open separate PR(s) for the rest on an as-needed basis. |
@henrikssn, you probably won't be able to rebase. Might be easier to just add it fresh. But #467 has been merged now |
Done, please take another look. @TDHolmes now also added this for v1 SPI, thumbv7m and I2C. |
@henrikssn, I think you didn't pull the latest changes when you updated this PR, because your commits modify files in the If you update it, we can merge |
I have lots of things going on right now, I'll try to get to it "soon". Please bare with me :) |
No worries. I didn't even notice this PR for the past 6 weeks, so... |
@henrikssn, still interested in following up with this? We're all busy, so 9 months isn't that long of a wait :p |
Summary
Make SPI Error support the defmt::Format trait (behind the
defmt
feature)Checklist
CHANGELOG.md
for the BSP or HAL updated