Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feather_m4 bsp and examples to v2 as much as possible #487

Merged
merged 7 commits into from
Oct 10, 2021

Conversation

TDHolmes
Copy link
Contributor

@TDHolmes TDHolmes commented Sep 19, 2021

Wasn't too bad, mostly used feather_m0's transformation as a guide. I was able to test:

  • blinky_basic
  • dmac
  • neopixel_rainbow
  • pwm
  • sleeping_timer_rtc
  • timers
  • trng
  • usb_echo

I couldn't validate:

  • uart
  • uart_poll_echo
  • serial

Unfortunately, sleeping_timer_rtc seems to not work. As that is my example, I'm going to take a look at this and see if I can fix it and/or if it's limited to M4

TODOs:

@TDHolmes
Copy link
Contributor Author

sleeping_timer_rtc also fails on feather_m0, so doesn't seem related to this refactor (that would've been shocking...)

@TDHolmes TDHolmes mentioned this pull request Sep 19, 2021
10 tasks
@jbeaurivage
Copy link
Contributor

@TDHolmes, thanks for working on this. I think the only thing I see missing is switching to spi::v2 in lib.rs.

@TDHolmes
Copy link
Contributor Author

TDHolmes commented Sep 24, 2021

I just updated to v2 SPI, but I am not confident in the change I made to be honest. Looking at the data sheet, it seems like the SPI hookup used by the feather board shouldn't work. The IoSet doesn't seem to match up even though they all are on Sercom1.

PA17 Sclk - IoSet1
PB23 Mosi - IoSet3
PB22 Miso - IoSet3

I added IoSet3 as another option for PA17 on Sercom1. @jbeaurivage / @bradleyharden is it possible the data sheet just omitted this?

image

@TDHolmes TDHolmes mentioned this pull request Oct 5, 2021
3 tasks
@TDHolmes TDHolmes force-pushed the feather_m4-v2-update branch 2 times, most recently from 8e883da to 554ba56 Compare October 9, 2021 17:57
@bradleyharden
Copy link
Contributor

I won't try auto merge for this. I expect there will be a conflict with #506. But it should be ready for merge

@TDHolmes
Copy link
Contributor Author

I'll need to edit this a bit after rebasing. I'll ping ya when I do it later tonight

@bradleyharden
Copy link
Contributor

Have you seen #445? Could you add that pin as well?

@TDHolmes TDHolmes force-pushed the feather_m4-v2-update branch from 0488675 to 19da5e1 Compare October 10, 2021 03:06
@TDHolmes
Copy link
Contributor Author

@bradleyharden ah let me sneak that in

crates.json Outdated Show resolved Hide resolved
@TDHolmes
Copy link
Contributor Author

@bradleyharden should be good to go!

@bradleyharden bradleyharden merged commit 4ecfc37 into atsamd-rs:master Oct 10, 2021
@TDHolmes TDHolmes deleted the feather_m4-v2-update branch October 10, 2021 17:22
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants