Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten HAL and move common content to crate root #425

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

glaeqen
Copy link
Contributor

@glaeqen glaeqen commented Apr 6, 2021

WiP: I published this PR in parallel to #424 for review purposes. Preferably #424 is going to be merged in first; thus, samd{1,2}1 modules will be absent and HAL structure will become much cleaner.
#424 is already in.

  • Incorporate common/mod.rs into lib.rs
  • Create a shim implementation of common module inside of lib.rs for backward compatibility
  • Removed common/mod.rs
  • Moved common/* to crate root

Long term goals note:

  • Get rid of the shim as soon as API breakage is acceptable (BSCs + examples are reworked)
  • Make other implementation-leaking modules (thumbv6m, thumbv7em) private

@glaeqen glaeqen mentioned this pull request Apr 7, 2021
@glaeqen glaeqen force-pushed the drop-common branch 2 times, most recently from 3cf2e3d to 8c39656 Compare April 12, 2021 06:58
Copy link
Contributor

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! I'd just like to have another set of eyes on it before merging due to the number of changes made, just to be safe.

@bradleyharden
Copy link
Contributor

@jessebraham, should we move forward with this?

@sajattack sajattack merged commit 094a8d4 into atsamd-rs:master Apr 26, 2021
@glaeqen glaeqen deleted the drop-common branch September 8, 2021 14:02
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants