Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota thermostat management #58

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

atrovato
Copy link
Owner

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@atrovato atrovato mentioned this pull request Oct 30, 2022
@atrovato atrovato linked an issue Oct 30, 2022 that may be closed by this pull request
@atrovato atrovato force-pushed the tasmota-thermostat branch from caf9c1e to 3d5df8a Compare March 18, 2023 18:12
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf5d96d
Status: ✅  Deploy successful!
Preview URL: https://2e65eb04.gladys.pages.dev
Branch Preview URL: https://tasmota-thermostat.gladys.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa0bed) 98.19% compared to head (cf5d96d) 98.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         786      787    +1     
  Lines       12307    12311    +4     
=======================================
+ Hits        12085    12089    +4     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atrovato atrovato added the enhancement New feature or request label Mar 18, 2023
@atrovato atrovato force-pushed the tasmota-thermostat branch 2 times, most recently from 55403f2 to 04fc8c5 Compare April 1, 2023 08:04
@atrovato atrovato marked this pull request as draft April 10, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thermostat on Tasmota
1 participant