Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dependencies #34

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Clean dependencies #34

wants to merge 2 commits into from

Conversation

atrovato
Copy link
Owner

@atrovato atrovato commented Dec 5, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #34 (b6f913b) into master (f1f4887) will decrease coverage by 0.99%.
The diff coverage is n/a.

❗ Current head b6f913b differs from pull request most recent head 23f09d2. Consider uploading reports for the commit 23f09d2 to get more accurate results

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   97.55%   96.57%   -0.99%     
==========================================
  Files         652      615      -37     
  Lines        9909     8844    -1065     
==========================================
- Hits         9667     8541    -1126     
- Misses        242      303      +61     

see 211 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atrovato atrovato force-pushed the clean-dependencies branch from fc2eb85 to f92945c Compare March 5, 2022 10:41
@atrovato atrovato force-pushed the clean-dependencies branch 2 times, most recently from 76033ed to bc29773 Compare December 1, 2022 21:06
@atrovato atrovato force-pushed the clean-dependencies branch from bc29773 to 23f09d2 Compare March 21, 2023 21:32
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 23f09d2
Status: ✅  Deploy successful!
Preview URL: https://0e0dae4e.gladys.pages.dev
Branch Preview URL: https://clean-dependencies.gladys.pages.dev

View logs

@atrovato atrovato marked this pull request as draft May 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant