Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote box #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remote box #103

wants to merge 1 commit into from

Conversation

atrovato
Copy link
Owner

@atrovato atrovato commented Jul 3, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d96d490
Status: ✅  Deploy successful!
Preview URL: https://471bba78.gladys.pages.dev
Branch Preview URL: https://remote-box.gladys.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa0bed) 98.19% compared to head (d96d490) 98.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         786      786           
  Lines       12307    12307           
=======================================
  Hits        12085    12085           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant