fix(:label:) fixing type annotations

react-docgen-typescript was removing color from the prop list
atomicpages · Sep 9, 2020 · d285de7 · d285de7
1 parent 0523b81
commit d285de7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/components/checkbox/useIndeterminate.ts b/src/components/checkbox/useIndeterminate.ts
@@ -35,6 +35,10 @@ export const useIndeterminate = ({
             typeof indeterminateFromProps !== 'undefined'
         ) {
             ref.current.checked = indeterminateFromProps;
+
+            // fix needs to come from pretty-checkbox
+            // ref.current.indeterminate = indeterminateFromProps;
+
             setStatus(indeterminateFromProps);
         }
     }, [indeterminateFromProps, state]);

diff --git a/src/typings/PCRCommonProps.d.ts b/src/typings/PCRCommonProps.d.ts
@@ -1,9 +1,9 @@
 import * as React from 'react';
 
-type Colors = 'primary' | 'success' | 'info' | 'warning' | 'danger';
+export type Colors = 'primary' | 'success' | 'info' | 'warning' | 'danger';
 type ColorsOutline = 'primary-o' | 'success-o' | 'info-o' | 'warning-o' | 'danger-o';
 
-export type CommonProps<S> = React.InputHTMLAttributes<HTMLInputElement> & {
+export type CommonProps<S> = Omit<React.InputHTMLAttributes<HTMLInputElement>, 'color'> & {
     /**
      * Set true to enable locked mode.
      */

diff --git a/src/typings/PCRSwitchProps.d.ts b/src/typings/PCRSwitchProps.d.ts
@@ -1,13 +1,18 @@
-import { CommonProps } from './PCRCommonProps';
+import { CommonProps, Colors } from './PCRCommonProps';
 
 type Shape = 'fill' | 'slim';
 
-export type PCRSwitchProps<S = any> = Omit<CommonProps<S>, 'variation' | 'animation'> & {
+export type PCRSwitchProps<S = any> = Omit<CommonProps<S>, 'variation' | 'animation' | 'color'> & {
     /**
      * The shape of the Switch.
      */
     shape?: Shape;
 
+    /**
+     * Choose a color. Note: solid colors only for switch.
+     */
+    color: Colors;
+
     /**
      * Switch has built-in animations. Do not specify
      * an animation.