1.0.5

* Simplifying API for components with no labels
atomicpages · Feb 6, 2019 · 373bfdd · 373bfdd
1 parent dae83f4
commit 373bfdd
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 11 deletions.
diff --git a/docs/package.json b/docs/package.json
@@ -22,7 +22,7 @@
         "markdown": "^0.5.0",
         "moize": "^5.4.1",
         "pretty-checkbox": "^3.0.3",
-        "pretty-checkbox-react": "^0.0.10",
+        "pretty-checkbox-react": "^1.0.0",
         "react": "^16.7.0",
         "react-dom": "^16.7.0",
         "react-live": "^1.12.0",

diff --git a/docs/yarn.lock b/docs/yarn.lock
@@ -8248,10 +8248,10 @@ pretty-bytes@^4.0.2:
   resolved "https://registry.yarnpkg.com/pretty-bytes/-/pretty-bytes-4.0.2.tgz#b2bf82e7350d65c6c33aa95aaa5a4f6327f61cd9"
   integrity sha1-sr+C5zUNZcbDOqlaqlpPYyf2HNk=
 
-pretty-checkbox-react@^0.0.10:
-  version "0.0.10"
-  resolved "https://registry.yarnpkg.com/pretty-checkbox-react/-/pretty-checkbox-react-0.0.10.tgz#31471b2fe8c1ec58911badc0e1cd81b41194a00f"
-  integrity sha512-qV95HUpQa4h6x6LRZSJKn+skKqo0TXDmuXybot2EaT9gOFcHIheNC17yE11t74n2N8x1Q/Hcq8+eO/+MR51DXw==
+pretty-checkbox-react@^1.0.0:
+  version "1.0.4"
+  resolved "https://registry.yarnpkg.com/pretty-checkbox-react/-/pretty-checkbox-react-1.0.4.tgz#1a5a0afaa5d3b6ae1d0445286b2140c21d8a6124"
+  integrity sha512-cSWUkVavIcPPIvCcYA+UZe6yclcrQ6D+a5v3MpqAqfvNh1hj9xMIaiPvwTB/0GH2LoqkbSVxsLTulEgZH8wLaw==
   dependencies:
     classnames "^2.2.6"
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "pretty-checkbox-react",
-    "version": "1.0.4",
+    "version": "1.0.5",
     "description": "Quickly integrate pretty checkbox Components (checkbox, switch, radio) with React",
     "keywords": [
         "Pretty",

diff --git a/src/components/Input.js b/src/components/Input.js
@@ -203,7 +203,7 @@ const PrettyInputState = (props: InputProps): React.Node => {
     return (
         <div className={classNames('state', color ? PREFIX + color : null)} data-testid="pcr-state">
             {node ? fillClassNameForIcons(node.node, node.className) : null}
-            {children ? <label htmlFor={id}>{children}</label> : null}
+            <label htmlFor={id}>{children}</label>
         </div>
     );
 };

diff --git a/src/components/__tests__/__snapshots__/Checkbox.test.js.snap b/src/components/__tests__/__snapshots__/Checkbox.test.js.snap
@@ -15,7 +15,11 @@ exports[`Checkbox tests Basic Checkbox usage should behave as a checkbox 1`] = `
     <div
       class="state"
       data-testid="pcr-state"
-    />
+    >
+      <label
+        for="foo"
+      />
+    </div>
   </div>
 </div>
 `;
diff --git a/src/components/__tests__/__snapshots__/Radio.test.js.snap b/src/components/__tests__/__snapshots__/Radio.test.js.snap
@@ -15,7 +15,11 @@ exports[`Radio tests Radio usage as a radio should behave as a radio 1`] = `
     <div
       class="state"
       data-testid="pcr-state"
-    />
+    >
+      <label
+        for="foo"
+      />
+    </div>
   </div>
 </div>
 `;

diff --git a/src/components/__tests__/__snapshots__/Switch.test.js.snap b/src/components/__tests__/__snapshots__/Switch.test.js.snap
@@ -15,7 +15,11 @@ exports[`Switch tests Switch usage as a radio should behave as a radio 1`] = `
     <div
       class="state"
       data-testid="pcr-state"
-    />
+    >
+      <label
+        for="foo"
+      />
+    </div>
   </div>
 </div>
 `;
-Original file line number
+Diff line change
@@ Expand Up @@
         <div
           class="state"
           data-testid="pcr-state"
-        />
+        >
+          <label
+            for="foo"
+          />
+        </div>
       </div>
     </div>
     `;
@@ Expand Down @@