Merge pull request #300 from atom/failing-test-electron-5

Fix failing test that overrides core packages
atom · Feb 13, 2020 · 36054ba · 36054ba
2 parents a54d618 + 8e9bc64
commit 36054ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/snippets.js b/lib/snippets.js
@@ -218,7 +218,7 @@ module.exports = {
   loadPackageSnippets (callback) {
     const disabledPackageNames = atom.config.get('core.packagesWithSnippetsDisabled') || []
     const packages = atom.packages.getLoadedPackages().sort((pack, _) => {
-      return /\/app\.asar\/node_modules\//.test(pack.path) ? -1 : 1
+      return /\/node_modules\//.test(pack.path) ? -1 : 1
     })
 
     const snippetsDirPaths = []

diff --git a/spec/snippet-loading-spec.js b/spec/snippet-loading-spec.js
@@ -93,10 +93,10 @@ describe("Snippet Loading", () => {
 
   describe("::loadPackageSnippets(callback)", () => {
     beforeEach(() => { // simulate a list of packages where the javascript core package is returned at the end
-      atom.packages.getLoadedPackages.andReturn([
+       atom.packages.getLoadedPackages.andReturn([
         atom.packages.loadPackage(path.join(__dirname, 'fixtures', 'package-with-snippets')),
         atom.packages.loadPackage('language-javascript')
-      ]);
+      ])
     });
 
     it("allows other packages to override core packages' snippets", () => {