Skip to content
This repository has been archived by the owner on Apr 7, 2021. It is now read-only.

Use a time based comparison #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use a time based comparison #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d82ad9
Use a time based comparison
Dec 8, 2017
0b5a27b
Catch TypeErrors
Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions server.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,18 @@ server = Http.createServer (req, resp) ->

hmac_digest = hmac.digest('hex')

if hmac_digest == query_digest
url = Url.parse dest_url

process_url url, transferredHeaders, resp, max_redirects
else
four_oh_four(resp, "checksum mismatch #{hmac_digest}:#{query_digest}")
try
if Crypto.timingSafeEqual(Buffer.from(hmac_digest), Buffer.from(query_digest))
url = Url.parse dest_url
process_url url, transferredHeaders, resp, max_redirects
else
four_oh_four(resp, "checksum mismatch #{hmac_digest}:#{query_digest}")
catch e
if e instanceof TypeError
return four_oh_four(resp, "could not compare checksum")
else
throw e

else
four_oh_four(resp, "No pathname provided on the server")

Expand Down
23 changes: 16 additions & 7 deletions server.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.