Bug fix: Adjust the on boarding screens to be scrollable #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irirwanirira
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #129 +/- ##
========================================
Coverage 72.22% 72.22%
========================================
Files 3 3
Lines 18 18
Branches 3 3
========================================
Hits 13 13
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Irirwanirira
force-pushed
the
bg-onboardingScreen
branch
2 times, most recently
from
2e1a005 to
cafc08a
Compare
Irirwanirira
force-pushed
the
bg-onboardingScreen
branch
from
cafc08a to
e37a575
Compare
mr3nz1
force-pushed
the
bg-onboardingScreen
branch
from
2a3cd7d to
0c4a975
Compare
*fix(favoriteDoctors-screen):Enhance UI and add dark theme
*fix(favoriteDoctors-screen):Enhance UI and add dark theme
*fix-doctor-details-screen-added
*fix-SignupAndLogin-screen-added
*fix-SignupAndLogin-screen-added
*fix-AddNewCard-Screen-added
*bg: fix appointment
*feat:setting up the dark theme for some screens.
*fix-doctor-details-screen-added
bg: fix merge conflicts
*fix-AddNewCard-Screen-added
*bg: reset release commits
*ch(githubAction-build):Change eas.json,app.json,app.json format ,to allow dynmic build for ios and android
*bg: Adjust scollable onboarding screens
*ch(githubAction-build):Change eas.json,app.json,app.json format ,to allow dynmic build for ios and android
*bg: Adjust scollable onboarding screens
*bg: onboarding alignment fix
mr3nz1
force-pushed
the
bg-onboardingScreen
branch
from
0c4a975 to
8d28541
Compare
mr3nz1
approved these changes
Jun 7, 2024
Paccyfic
approved these changes
Jun 7, 2024
Nkbtemmy
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request adds updates to the onboarding screens of the medical app to ensure that users can scroll through different screens compatibility with both dark and light modes. It includes adjustments to the UI elements, colors, and layouts to maintain consistency and readability across different modes.
Description of Task to be completed?
The fix involved reviewing the existing onboarding screens and making necessary adjustments to ensure they are visually appealing and functional in both dark and light modes. This includes modifying color schemes, updating text styles, and adjusting layout spacing where necessary.
How should this be manually tested?
These changes could be tested by running the app on your Android Studio emulator or by having the Expo app installed on your phone and scanning the QR code to try the app.
Screenshots