Enhance Notification screen UI and Dark theme #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr3nz1
approved these changes
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #105 +/- ##
========================================
Coverage 72.22% 72.22%
========================================
Files 3 3
Lines 18 18
Branches 3 3
========================================
Hits 13 13
Misses 5 5 ☔ View full report in Codecov by Sentry. |
23nosurrend
force-pushed
the
fix-notification-Screen
branch
2 times, most recently
from
21ef826 to
90f60f8
Compare
23nosurrend
force-pushed
the
fix-notification-Screen
branch
from
90f60f8 to
840be3e
Compare
Irirwanirira
force-pushed
the
fix-notification-Screen
branch
from
840be3e to
3169bb0
Compare
Irirwanirira
added
Need Review
Nkbtemmy
requested changes
May 31, 2024
.env
Outdated
Comment on lines
1
to
2
| EXPO_PUBLIC_API_URL=http://api.local | ||
| EXPO_PUBLIC_API_KEY=abc123 |
Irirwanirira
force-pushed
the
fix-notification-Screen
branch
from
3169bb0 to
4acd831
Compare
Nkbtemmy
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhance UI and Add Dark Theme for Notification Screen
Description:
This PR focuses on enhancing the UI and adding a dark theme to the Notification Screen. The current implementation has several issues that need to be addressed to ensure a seamless and aesthetically pleasing user experience. The specific areas that require attention include:
Dynamic Theme Handling:
Ensure that the background color and other UI elements adjust dynamically based on the selected theme (light or dark).
Notification Layout: Improve the layout and appearance of notification items for better readability and visual appeal.
Tasks:
Dynamic Theme Handling:
Ensure that all notification items are well-organized and visually appealing.
Check for any overlapping text or UI elements and resolve them.
Improve the layout for better readability.
Theme-Specific Adjustments:
Light Theme: Ensure that the background and text colors provide sufficient contrast for readability.
Dark Theme: Apply dark background colors and light text colors for better visibility in low-light conditions.
Adjust icon colors to ensure they are clearly visible in both themes.
Screenshot