New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#187454781 Configure eslint and git pre-commit #9

Merged

leandreAlly merged 3 commits into develop from feat-eslint-precommit-hook-187419039

Apr 22, 2024

Collaborator

GarrixA commented Apr 18, 2024 •

edited

Loading

What I did is:

setting up eslint code format
git pre-commit

What does this do

The eslint sets up rules for formatting our code in the development so that every one must follow it.
Git pre-commit ensures that before we commit any changes, our codes follows eslint rules

Here is how you can check it

Run npm install to install all the packages
Run npm run check to format your codes
Run npm run lint to check linting errors
After knowing how it works you can add commit

Pivotracker ID
#187454781

GarrixA requested review from leandreAlly, cyusasnave, dniwemugisha and YvetteNyibuka

April 18, 2024 09:00

GarrixA self-assigned this

GarrixA force-pushed the feat-eslint-precommit-hook-187419039 branch from 1303b99 to b26977a Compare

April 18, 2024 09:26

GarrixA added the Ready for Review label

GarrixA force-pushed the feat-eslint-precommit-hook-187419039 branch 3 times, most recently from 9f79022 to 36c9fd1 Compare

April 19, 2024 14:45

hound bot reviewed

View reviewed changes

eslint.config.js

+              	{
+              		files: ["*.ts", "*.js"],
+              		...tseslint.configs.disableTypeChecked,
+              	},

hound bot Apr 19, 2024

Unexpected '}'.

eslint.config.js

+              	},
+              	{
+              		files: ["*.ts", "*.js"],
+              		...tseslint.configs.disableTypeChecked,

hound bot Apr 19, 2024

Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (38% scanned).

eslint.config.js

+              		ignores: ["**/__test__", "**/*.json"],
+              	},
+              	eslint.configs.recommended,
+              	...tseslint.configs.recommended,

hound bot Apr 19, 2024

'spread/rest operator' is only available in ES6 (use 'esversion: 6').

eslint.config.js

		@@ -0,0 +1,51 @@
		const eslint = require("@eslint/js");
		const tseslint = require("typescript-eslint");

hound bot Apr 19, 2024

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

eslint.config.js

		@@ -0,0 +1,51 @@
		const eslint = require("@eslint/js");

hound bot Apr 19, 2024

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

GarrixA force-pushed the feat-eslint-precommit-hook-187419039 branch from 36c9fd1 to f9dbcb8 Compare

April 19, 2024 15:23

GarrixA added 2 commits

April 21, 2024 23:49


          chore(eslint): eslint and git pre-commit

3e6cd07


          chore(eslint): eslint and git pre-commit

bbdaf85

GarrixA force-pushed the feat-eslint-precommit-hook-187419039 branch from f9dbcb8 to 630f573 Compare

April 21, 2024 22:01

cyusasnave approved these changes

View reviewed changes

cyusasnave requested changes

View reviewed changes

package.json Show resolved Hide resolved

hound bot reviewed

View reviewed changes

src/database/migrations/20240419093334-create_users_table.js

-                  });
-                },
+              	async up(queryInterface, Sequelize) {
+              		await queryInterface.createTable("users", {

hound bot Apr 22, 2024

Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound bot reviewed

View reviewed changes

src/database/migrations/20240419093334-create_users_table.js

-                  });
-                },
+              	async up(queryInterface, Sequelize) {
+              		await queryInterface.createTable("users", {

hound bot Apr 22, 2024

Expected an assignment or function call and instead saw an expression.
Missing semicolon.


          chore(eslint): eslint and git pre-commit

74adf58

GarrixA force-pushed the feat-eslint-precommit-hook-187419039 branch from 10bb473 to 74adf58 Compare

April 22, 2024 09:02

hound bot reviewed

View reviewed changes

src/database/migrations/20240419093334-create_users_table.js

+              				allowNull: false,
+              				type: Sequelize.DATE,
+              			},
+              		});

hound bot Apr 22, 2024

Unrecoverable syntax error. (88% scanned).

src/database/migrations/20240419093334-create_users_table.js

-                    },
-                  });
-                },
+              	async up(queryInterface, Sequelize) {

hound bot Apr 22, 2024

Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 5 and instead saw '{'.
Missing semicolon.

hound bot reviewed

View reviewed changes

src/database/migrations/20240419093334-create_users_table.js

+              				allowNull: false,
+              				type: Sequelize.DATE,
+              			},
+              		});

hound bot Apr 22, 2024

Unrecoverable syntax error. (88% scanned).

src/database/migrations/20240419093334-create_users_table.js

-                    },
-                  });
-                },
+              	async up(queryInterface, Sequelize) {

hound bot Apr 22, 2024

Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 5 and instead saw '{'.
Missing semicolon.

src/database/seeders/20240415192800-demo-user.js

+              				},
+              			],
+              			{},
+              		);

hound bot Apr 22, 2024

Expected ')' and instead saw ';'.
Expected an identifier and instead saw ')'.
Missing semicolon.
Unexpected ')'.
Unrecoverable syntax error. (78% scanned).

src/database/seeders/20240415192800-demo-user.js

-                async down(queryInterface, Sequelize) {
-                  await queryInterface.bulkDelete("users", null, {});
-                },
+              	async up(queryInterface, Sequelize) {

hound bot Apr 22, 2024

Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.

codeclimate bot reviewed

View reviewed changes

codeclimate bot left a comment

The PR diff size of 19755 lines exceeds the maximum allowed for the inline comments feature.

codeclimate bot commented Apr 22, 2024

Code Climate has analyzed commit 74adf58 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 30.7% (60% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

GarrixA requested a review from cyusasnave

April 22, 2024 09:05

cyusasnave approved these changes

View reviewed changes

YvetteNyibuka approved these changes

View reviewed changes

Collaborator

YvetteNyibuka left a comment

Good Job @GarrixA !

leandreAlly approved these changes

View reviewed changes

leandreAlly merged commit 22a9f66 into develop

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hound[bot] hound[bot] left review comments

codeclimate[bot] codeclimate[bot] left review comments

leandreAlly leandreAlly approved these changes

YvetteNyibuka YvetteNyibuka approved these changes

cyusasnave cyusasnave approved these changes

dniwemugisha Awaiting requested review from dniwemugisha

Labels

Ready for Review