#187419063- Build Rest End Points for ROLE #19

Tuyisenge2 · 2024-04-24T17:00:23Z

What does this PR do?

Admin should be able to assign various users to various roles

Description of Task to be completed?

having following endpoints working
-POST api/v1/roles
-POST api/v1/users/:userId/roles
-PATCH api/v1/roles/:id
-DELETE api/v1/roles/:id

How should this be manually tested?

After cloning the repo, cd into it and first RUN npm migrate and then RUN npm run dev
Using Postman test every endpoint above with this header:
key: Content-Type value: application/json
To test authentication, add this to the header: Get TOKEN from login endpoint
key: Authorization value: JWT TOKEN

hound · 2024-04-26T12:30:09Z

src/__test__/role.test.ts

@@ -0,0 +1,185 @@
+import app from "../app";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T15:03:36Z

src/controllers/roleConroller.ts

@@ -0,0 +1,98 @@
+import { Request, Response } from "express";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T15:03:36Z

src/database/migrations/20240425075822-create-role.js

+"use strict";
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+	async up(queryInterface, Sequelize) {


Parsing error: Unexpected token up

hound · 2024-04-29T15:03:36Z

src/database/models/User.ts

-import { DataTypes, Model, Optional, UUIDV4 } from "sequelize";
-import { sequelizeConnection } from "../config/db.config";
-
+import { DataTypes, Model, Optional, Sequelize, UUIDV4 } from "sequelize";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

codeclimate · 2024-04-29T15:04:54Z

src/documention/role/index.ts

+			responses,
+		},
+	},
+	"/roles/{id}": {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-29T15:04:54Z

src/database/seeders/20240428145740-demo-user.js

+		await queryInterface.bulkInsert(
+			"users",
+			[
+				{


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-04-29T15:04:54Z

src/database/seeders/20240428145740-demo-user.js

+					createdAt: new Date(),
+					updatedAt: new Date(),
+				},
+				{


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-04-29T15:04:54Z

src/database/seeders/20240428145740-demo-user.js

+					createdAt: new Date(),
+					updatedAt: new Date(),
+				},
+				{


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-04-29T15:04:54Z

src/middlewares/role.middleware.ts

+import { NextFunction, Request, Response } from "express";
+import { HttpException } from "../utils/http.exception";
+
+export const roleNameValid = async (


Similar blocks of code found in 2 locations. Consider refactoring.

hound · 2024-04-29T21:48:49Z

src/database/models/index.ts

@@ -0,0 +1,10 @@
+import { Sequelize } from "sequelize";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T21:48:49Z

src/database/models/role.ts

@@ -0,0 +1,35 @@
+import { DataTypes, Sequelize, Model, Optional, UUIDV4 } from "sequelize";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T21:48:49Z

src/database/seeders/20240427093240-demo-roles.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+	async up(queryInterface) {


Parsing error: Unexpected token up

hound · 2024-04-29T21:48:50Z

src/database/seeders/20240428145740-demo-user.js

@@ -0,0 +1,58 @@
+const bcrypt = require("bcrypt");
+const hashPassword = async (password) => {


Parsing error: Unexpected token =>

hound · 2024-04-29T21:48:50Z

src/documention/role/index.ts

@@ -0,0 +1,100 @@
+import { responses } from "../responses";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T21:48:50Z

src/middlewares/role.middleware.ts

@@ -0,0 +1,64 @@
+import {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T21:48:50Z

src/routes/roleRoutes.ts

@@ -0,0 +1,18 @@
+import {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2024-04-29T21:48:50Z

src/validations/role.validation.ts

@@ -0,0 +1,25 @@
+import Joi from "joi";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

codeclimate · 2024-04-29T21:49:57Z

src/__test__/role.test.ts

+		expect(body.message).toStrictEqual("Please Login Again");
+	});
+
+	it("it should return Invalid token and return 403 ", async () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-29T21:49:57Z

src/middlewares/role.middleware.ts

+	}
+};
+
+export const roleIdValidations = async (


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-29T21:49:57Z

src/__test__/users.test.ts

+} from "../mock/static";
+const role = database_models["role"];
+jest.setTimeout(30000);
+function logErrors(


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-29T21:49:57Z

src/__test__/role.test.ts

+	UserId?: JwtPayload;
+}
+
+function logErrors(


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-29T21:49:57Z

src/documention/role/index.ts

+			responses,
+		},
+	},
+	"/users/{userId}/roles": {


Similar blocks of code found in 2 locations. Consider refactoring.

hound · 2024-04-30T13:09:25Z

src/database/migrations/20240430113742-create-token-table.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+	async up(queryInterface, Sequelize) {


Parsing error: Unexpected token up

codeclimate · 2024-04-30T13:13:37Z

src/__test__/role.test.ts

+	UserId?: JwtPayload;
+}
+
+function logErrors(


Identical blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-04-30T13:13:37Z

src/__test__/role.test.ts

+		// await deleteTableData(database_models.role, "roles");
+	});
+
+	it("it should  register a user and return 201", async () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-30T13:13:37Z

src/__test__/role.test.ts

+		expect(body.message).toStrictEqual("Role assigned successfully!");
+	});
+
+	it("it should return please login and return 401 ", async () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-30T13:13:37Z

src/__test__/role.test.ts

+		expect(body.status).toStrictEqual(409);
+	});
+
+	it("it should return role not found and return 404 ", async () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-30T13:13:37Z

src/__test__/role.test.ts

+		expect(body.message).toStrictEqual("role not found");
+	});
+
+	it("it should assign user to role  and return 201 ", async () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-30T13:13:39Z

Code Climate has analyzed commit 382514f and detected 19 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Duplication	18

The test coverage on the diff in this pull request is 91.1% (60% is the threshold).

This pull request will bring the total coverage in the repository to 91.2% (0.0% change).

View more on Code Climate.

Tuyisenge2 requested review from GarrixA, cyusasnave, dniwemugisha and leandreAlly April 24, 2024 17:00

Tuyisenge2 added the WIP label Apr 24, 2024

Tuyisenge2 changed the title ~~#187419063- Build Rest End Points for Resources~~ #187419063- Build Rest End Points for ROLE Apr 24, 2024

hound bot reviewed Apr 26, 2024

View reviewed changes

Tuyisenge2 force-pushed the feat-Roles-Permission-187419063 branch 19 times, most recently from 7fdce1f to 4089153 Compare April 29, 2024 15:03

hound bot reviewed Apr 29, 2024

View reviewed changes

codeclimate bot reviewed Apr 29, 2024

View reviewed changes

Tuyisenge2 added Ready for Review and removed WIP labels Apr 29, 2024

Tuyisenge2 force-pushed the feat-Roles-Permission-187419063 branch from 4089153 to 23c9398 Compare April 29, 2024 21:48

hound bot reviewed Apr 29, 2024

View reviewed changes

codeclimate bot reviewed Apr 29, 2024

View reviewed changes

Tuyisenge2 added 2 commits April 30, 2024 11:21

feat(role): implementing role feature

84c5fdd

feat(ROLES): implement ASSIGNING ROLE ON USERS

382514f

Tuyisenge2 force-pushed the feat-Roles-Permission-187419063 branch from 23c9398 to 382514f Compare April 30, 2024 13:09

hound bot reviewed Apr 30, 2024

View reviewed changes

codeclimate bot reviewed Apr 30, 2024

View reviewed changes

cyusasnave approved these changes Apr 30, 2024

View reviewed changes

GarrixA approved these changes Apr 30, 2024

View reviewed changes

leandreAlly approved these changes Apr 30, 2024

View reviewed changes

leandreAlly merged commit 76408a9 into develop Apr 30, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#187419063- Build Rest End Points for ROLE #19

#187419063- Build Rest End Points for ROLE #19

Tuyisenge2 commented Apr 24, 2024

hound bot Apr 26, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

codeclimate bot Apr 29, 2024

hound bot Apr 30, 2024

codeclimate bot Apr 30, 2024

codeclimate bot Apr 30, 2024

codeclimate bot Apr 30, 2024

codeclimate bot Apr 30, 2024

codeclimate bot Apr 30, 2024

codeclimate bot commented Apr 30, 2024

		@@ -0,0 +1,98 @@
		import { Request, Response } from "express";

		@@ -0,0 +1,35 @@
		import { DataTypes, Sequelize, Model, Optional, UUIDV4 } from "sequelize";

		@@ -0,0 +1,58 @@
		const bcrypt = require("bcrypt");
		const hashPassword = async (password) => {

#187419063- Build Rest End Points for ROLE #19

#187419063- Build Rest End Points for ROLE #19

Conversation

Tuyisenge2 commented Apr 24, 2024

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 30, 2024

Choose a reason for hiding this comment

codeclimate bot commented Apr 30, 2024