Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stock quantity update and verify user #95

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

yvanddniyo
Copy link
Collaborator

What this PR do ?

This PR is about to modify the stock quantity and verify user when sign up.

Description of the PR

Seller can be able to update delivery and will instantly and remove amount of the quantity purchased from the stock quantity.
User after sign should be to verify his or her email through he email.

How to test this PR manually?

Clone the repository.
Checkout to the branch fix-stock-quantity-verify-user
Run npm install to install dependencies.
Run npm run dev to start the development server and login
navigate to /register if you're a buyer
create your account with credential
You'll see email in your email inbox. and click to that link will navigate to the page.
Congratulation you have successfully verified as a new user.

@yvanddniyo yvanddniyo force-pushed the fix-stock-quantity-verify-user branch 2 times, most recently from 710202a to e8435a6 Compare July 23, 2024 14:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (e2bab33) to head (6d51509).

Files Patch % Lines
src/controllers/userControllers.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #95      +/-   ##
==========================================
+ Coverage   73.20%   73.37%   +0.17%     
==========================================
  Files         130      130              
  Lines        2362     2366       +4     
  Branches      303      302       -1     
==========================================
+ Hits         1729     1736       +7     
+ Misses        633      630       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yvanddniyo yvanddniyo force-pushed the fix-stock-quantity-verify-user branch from e8435a6 to 1190759 Compare July 23, 2024 14:40
@yvanddniyo yvanddniyo force-pushed the fix-stock-quantity-verify-user branch from 1190759 to bd3ecdc Compare July 24, 2024 09:12
    - seller when marked as delivery should decrease the quantity of the product
    - when user sign up should get verification link and be able to navigate to login

  - when order delivery should remove the amount of the quantiy purchased

[No Id]
@yvanddniyo yvanddniyo force-pushed the fix-stock-quantity-verify-user branch from bd3ecdc to 6d51509 Compare July 24, 2024 10:02
@teerenzo teerenzo merged commit 07072e9 into dev Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants