Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:user profile #94

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix:user profile #94

merged 1 commit into from
Jul 22, 2024

Conversation

niyobertin
Copy link
Collaborator

What does this PR do?
user profile modification

Description of Task to be completed?

  • user should be having pofile when he/she sigin in with google
  • user inf should be the same when a user update his/profile.

How should this be manually tested?
Clone the repo, cd into it: run

npm install: to install the dependences
npm run dev : to start the server.
Then try to sign in with goole. the check your profile.
update it and view the list of user you will see that your name hase been updated.

-user should be able to update prodile
-user should be able to update his/her info
-user should be able to create profile when user sign up with google.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (0df8206) to head (e446bf5).

Files Patch % Lines
src/controllers/userControllers.ts 60.00% 2 Missing ⚠️
src/services/user.service.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #94      +/-   ##
==========================================
- Coverage   73.24%   72.94%   -0.31%     
==========================================
  Files         130      130              
  Lines        2355     2362       +7     
  Branches      303      300       -3     
==========================================
- Hits         1725     1723       -2     
- Misses        630      639       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teerenzo teerenzo merged commit e2bab33 into dev Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants