Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft: auth (new user needs to verify one's account before login) #187419164 #65

Merged
merged 1 commit into from
May 29, 2024

Conversation

MugemaneBertin2001
Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 commented May 20, 2024

What does this PR do?

  • A successfully registered user should receive an email to verify their account email

How to manually test this feature manually?

  • clone this repo
  • set up local environment configuration
  • run app
  • browse to `localhost:499/docs

supporting screenshot

Screenshot 2024-05-20 201423

delivered future: #187419164

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch from 6dda574 to 9b9ab43 Compare May 21, 2024 13:41
Copy link

gitguardian bot commented May 21, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10538571 Triggered Generic Password 387960e test/user.test.ts View secret
10820488 Triggered Generic Password 387960e test/product.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch 10 times, most recently from 4022827 to f087adc Compare May 22, 2024 14:19
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch 5 times, most recently from dd70c15 to bfff83d Compare May 23, 2024 13:57
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch 2 times, most recently from 1ef3529 to 3d7bd46 Compare May 23, 2024 22:45
@MugemaneBertin2001 MugemaneBertin2001 changed the title Ft: auth (new user needs to verify one's account before login Ft: auth (new user needs to verify one's account before login) #187419164 May 23, 2024
@teerenzo teerenzo self-requested a review May 24, 2024 16:26
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch 19 times, most recently from ee0c6fe to 18c065c Compare May 29, 2024 00:25
mocked all email service calling during the test
@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-verify-registered-user-#187419164 branch from 18c065c to 387960e Compare May 29, 2024 00:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.92208% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 77.63%. Comparing base (9b8d8e4) to head (387960e).
Report is 2 commits behind head on dev.

Files Patch % Lines
src/services/user.service.ts 65.71% 12 Missing ⚠️
src/controllers/userControllers.ts 75.00% 4 Missing ⚠️
src/middlewares/isVerified.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #65      +/-   ##
==========================================
- Coverage   78.39%   77.63%   -0.77%     
==========================================
  Files         115      117       +2     
  Lines        1986     2057      +71     
  Branches      274      280       +6     
==========================================
+ Hits         1557     1597      +40     
- Misses        418      460      +42     
+ Partials       11        0      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Jovz19200 Jovz19200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Bertin

@teerenzo teerenzo merged commit 04225b4 into dev May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants