-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft: auth (new user needs to verify one's account before login) #187419164 #65
Conversation
6dda574
to
9b9ab43
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10538571 | Triggered | Generic Password | 387960e | test/user.test.ts | View secret |
10820488 | Triggered | Generic Password | 387960e | test/product.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
4022827
to
f087adc
Compare
dd70c15
to
bfff83d
Compare
1ef3529
to
3d7bd46
Compare
ee0c6fe
to
18c065c
Compare
mocked all email service calling during the test
18c065c
to
387960e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #65 +/- ##
==========================================
- Coverage 78.39% 77.63% -0.77%
==========================================
Files 115 117 +2
Lines 1986 2057 +71
Branches 274 280 +6
==========================================
+ Hits 1557 1597 +40
- Misses 418 460 +42
+ Partials 11 0 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job Bertin
What does this PR do?
How to manually test this feature manually?
repo
supporting screenshot
delivered future: #187419164