#187419169 As a user, I can log into the E-commerce application via email & password #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the JWT token -a user can login using email and password -if sucessfull it will return Json webtoken -if email & password miss match it will return message"bad compination of email and password -if email provided is not exist it will retun a message "User not found! please register a new ancount" [Finishes #187419169]
…m/atlp-rwanda/eagles-ec-be into ft-user-login-#187419169
…o ft-user-login-#187419169 fixed
-swagger documentartion on user login with eamil and password -test user login endpoint on successfull event and fail events [Finishes #187419169]
- user can be to sign up using name, username, email, and password. - user can't be able to sign up twice using same email. [Delivers #187431242]
…o ft-user-signup-#187431242
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10286351 | Triggered | Company Email Password | 9741ec3 | src/sequelize/seeders/20240412144111-demo-user.js | View secret |
| 10286352 | Triggered | Generic Password | 9741ec3 | src/sequelize/seeders/20240412144111-demo-user.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
niyobertin
requested review from
soleil00,
Heisjabo,
dniwemugisha,
MugemaneBertin2001,
teerenzo,
yvanddniyo and
Jovz19200
niyobertin
removed request for
dniwemugisha,
MugemaneBertin2001,
teerenzo,
Jovz19200,
Heisjabo,
yvanddniyo and
soleil00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provide login functionality to the E-commerce with email and password and return token as result of successful login.
It also have a swagger documentation for user login functionality and unity test for login endpoints.
Description of Task to be completed?
Have the following endpoint working
GET /api/v1/users
POST /api/v1/users/login
How should this be manually tested?
After cloning the repostory from here, cd into it and run npm run dev to start the server.
Using using postman test every end point.
Send GET request on localhost:8000/api/v1/users to get all users
Send POST request ton localhost:8000/api/v1/users/login to login with email and password. successful login will generate a jwt.
Using browser like chrome,Firefox,etc .., send a request on localhost:8000/docs for swagger documentation for login.
Run npm run test for testing login end pint.
What are the relevant pivotal tracker/Trello stories?
#187419169
Screenshots
the screenshot below show successful login