finishing password reset #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanIrad
requested review from
niyontwali,
Anguandia,
hozayves,
Mag-codes,
patrickhag and
Favor-star
✅ Deploy Preview for e-commerce-mavericks-fn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
from
b13f81c to
23eeb9c
Compare
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
2 times, most recently
from
de09fef to
ec59604
Compare
hozayves
requested changes
Jun 22, 2024
There was a problem hiding this comment.
Hey Jado,
I have a quick suggestion.
- Could you please remove the toastContainer from ResentPassword.tsx? It's already configured in App.tsx, so having it here seems redundant. You can refer to how Ange used react-toastify in LoginComponent.tsx for guidance.
- Let us know why you made changes in footer component
- and also your forgot password component is too much wider than usual on big screen. look on the way you can make it look good instead 50%
Thanks!
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
from
ec59604 to
e675b3e
Compare
I believe the same too |
I also refactored it |
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
from
e675b3e to
e309dcf
Compare
amin-leon
requested changes
Jun 27, 2024
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
from
e309dcf to
ccd84a9
Compare
I have rebased, you can check again |
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
4 times, most recently
from
cd51e26 to
cd7769f
Compare
finishing a rebase modified: src/App.tsx modified: src/components/authentication/LoginComponent.tsx modified: src/components/common/Button.tsx modified: src/components/footer/Footer.tsx new file: src/components/passwordReset/NewPasswordComponent.tsx new file: src/components/passwordReset/PasswordResetComponent.tsx new file: src/hooks/customHooks.ts new file: src/pages/NewPassword.tsx new file: src/pages/ResetPassword.tsx new file: src/services/resetPassword.ts modified: src/utils/schemas.ts
JeanIrad
force-pushed
the
187354199-ft-password-reset
branch
from
cd7769f to
e0a7f77
Compare
princenzmw
approved these changes
Jul 8, 2024
amin-leon
approved these changes
Jul 9, 2024
hozayves
approved these changes
Jul 10, 2024
niyontwali
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Password reset
##Password Reset
Describe the purpose of the PR
Changes Made
Describe the changes made
Testing Instructions
List all testing instruction, if availbale
Related Issues
Lists all related issues
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: