finishes#187354206 edit-user-profile #19
Closed
+249
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracemugwanezak
requested review from
niyontwali,
JeanIrad,
hozayves,
Mag-codes,
amin-leon and
Favor-star
✅ Deploy Preview for e-commerce-mavericks-fn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
6 times, most recently
from
2d43c06 to
0ca31ad
Compare
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
4 times, most recently
from
5f5e453 to
1269335
Compare
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
4 times, most recently
from
738d896 to
aad4200
Compare
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
2 times, most recently
from
722ddee to
0ba8442
Compare
JeanIrad
requested changes
Jul 12, 2024
| formState: { errors, isSubmitting }, | ||
| } = useForm<UserFormValues>(); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
why having 2 useEffect hooks? plus, setting the initial userData to the data being fetched,
if the data becomes undefined for some reasons, that would break the app
src/components/profile/Profile.tsx
Outdated
| formData.append('phoneNumber', data.phoneNumber); | ||
| formData.append('email', data.email); | ||
| formData.append('profileImage', data.photoUrl[0]); | ||
| // if (data.photoUrl && data.photoUrl[0]) { |
| setShowSuccessMessage(true); | ||
| setTimeout(() => setShowSuccessMessage(false), 3000); // Hide message after 3 seconds | ||
| } catch (err) { | ||
| console.error('Failed to update profile:', err); |
There was a problem hiding this comment.
this error caught should be handled properly displaying an appropriate message to the client
| } | ||
| }; | ||
|
|
||
| const getErrorMessage = (error: any) => { |
There was a problem hiding this comment.
I don't see where you are calling this function
| @@ -10,8 +11,20 @@ export const userApi = mavericksApi.injectEndpoints({ | |||
| }, | |||
| }), | |||
| }), | |||
| updateUser: builder.mutation({ | |||
There was a problem hiding this comment.
could you consider creating your own separate service for easy management?
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
from
0ba8442 to
92e9a9d
Compare
Finishes fixing homepage sign in links
gracemugwanezak
force-pushed
the
187354206-ft-edit-user-profile
branch
from
92e9a9d to
04f7389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PurposeEditing user-profile
Changes Made
Testing Instructions
no tests made
Related Issues
No issues
Checklist
Please review the following checklist and make sure all tasks are complete before submitting: