Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user type #143

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixed user type #143

merged 1 commit into from
Jul 10, 2024

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jul 9, 2024

Description

Enhancement: This pull request addresses the issue where the Get User Method was not returnig the user type

Changes Made

  1. Backend Changes:
    • Updated Get user Controller
    • Handled error on Momo Payment when the total amount is Zero.

How to Test

  1. Make Request to get User.
  2. Check if you sent zero Total amount on Momo Pay is returning a error message.

Related Issues

@13XAVI 13XAVI linked an issue Jul 9, 2024 that may be closed by this pull request
@13XAVI 13XAVI force-pushed the 142-fix-return-usertype branch from c2ca748 to b7552a2 Compare July 9, 2024 16:00
@13XAVI 13XAVI self-assigned this Jul 9, 2024
@13XAVI 13XAVI added bug Something isn't working backend Good for newcomers labels Jul 9, 2024
@13XAVI 13XAVI requested a review from niyobern July 9, 2024 16:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (325eacd) to head (0355f6c).

Files Patch % Lines
src/controller/userController.ts 40.90% 13 Missing ⚠️
src/controller/buyerController.ts 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    87.32%   87.19%   -0.13%     
===========================================
  Files           65       65              
  Lines         1680     1687       +7     
  Branches       181      184       +3     
===========================================
+ Hits          1467     1471       +4     
- Misses         189      191       +2     
- Partials        24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@13XAVI 13XAVI added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 9, 2024
@13XAVI 13XAVI force-pushed the 142-fix-return-usertype branch from b7552a2 to 0355f6c Compare July 10, 2024 06:08
@dushimeemma dushimeemma merged commit 26837ea into develop Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers bug Something isn't working Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Return UserType
6 participants