Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the ios build issue; #5

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

ashwinKashyapKrishna
Copy link
Contributor

@ashwinKashyapKrishna ashwinKashyapKrishna commented Sep 2, 2024

Fix for #4

Copy link
Owner

@atlj atlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for sending this!

@atlj
Copy link
Owner

atlj commented Sep 2, 2024

Screenshot 2024-09-02 at 19 01 47 Hey it looks like the CI is failing. Could you take a look?

@ashwinKashyapKrishna
Copy link
Contributor Author

Thanks for the response :)
Applied a fix, it built ok for the example project locally, maybe worth trying it with the CI once if thats ok

@charlemagneVI
Copy link

Is it possible to get this merged in? I think this issue blocks being able to use this package for iOS builds.

@atlj
Copy link
Owner

atlj commented Dec 17, 2024

@charlemagneVI thanks so much for the ping. Releasing now

@atlj atlj enabled auto-merge (squash) December 17, 2024 20:50
@atlj atlj disabled auto-merge December 17, 2024 20:50
@atlj atlj merged commit 5509649 into atlj:main Dec 17, 2024
4 checks passed
@atlj
Copy link
Owner

atlj commented Dec 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants