Conversation
Docker: Now copy files from folder instead of cloning repo
…auto detect device when doing rfcat -r
|
hey @CharlieBailly this looks very interesting. i haven't looked through it much yet, i've been on vacation. |
|
Hi @atlas0fd00m. Since the PandwaRF firmware is not open-source, I thought you may not want to add its support. But if you are interested in supporting the PandwaRF, I would be happy to merge it directly in the official repo. |
|
i don't prefer the firmware being closed, but i do appreciate the PandwaRF hardware, and i don't see any benefit to forcing you to keep a separate RfCat fork. i think we can all benefit from supporting additional hardware via RfCat. let me review the PR and see what you're asking to change. thanks, @CharlieBailly |
|
Hi @atlas0fd00m , I would love to see this PR from @CharlieBailly being merged, so please let me know if you need something to help in the resolution (BTW I am the creator of PandwaRF). Let me know if you need some HW to test or else. |
atlas0fd00m
left a comment
atlas0fd00m
left a comment
There was a problem hiding this comment.
damn! i didn't realize i had never submitted this review, i just wondered why you didn't respond!
please accept my apologies. i'm still committed to merging in pandwarf support in.
| @@ -1,23 +1,75 @@ | |||
| Welcome to the official rfcat project that works for `PandwaRF` and `PandwaRF Rogue`, modified to also work with legacy rfcat dongles such as `Yard Stick One`. | |||
There was a problem hiding this comment.
looking through the PR, the README.md is probably the most problematic for merge :)
since this is the official RfCat repo, too much emphasis on PandwaRF over other dongles may be considered inappropriate. ;)
There was a problem hiding this comment.
Yes sure, this is not the PandwaRF repo. So feel free to to treat PandwaRF as any other compatible dongle
| - [Legacy Readme](#legacy-readme) | ||
| - [Table of Contents](#table-of-contents) | ||
| - [GOALS](#goals) | ||
| - [REQUIREMENTS](#requirements) | ||
| - [Other requirements](#other-requirements) | ||
| - [Build requirements](#build-requirements) | ||
| - [DEVELOPMENT](#development) | ||
| - [Gotchas](#gotchas) | ||
| - [INSTALLING ON HARDWARE](#installing-on-hardware) | ||
| - [allowing non-root dongle access](#allowing-non-root-dongle-access) | ||
| - [supported dongles](#supported-dongles) | ||
| - [GoodFET](#goodfet) | ||
| - [Chronos Dongle](#chronos-dongle) | ||
| - [EMK Dongle](#emk-dongle) | ||
| - [YARD Stick One](#yard-stick-one) | ||
| - [INSTALLING WITH BOOTLOADER](#installing-with-bootloader) | ||
| - [Steps required for all firmware installs and updates](#steps-required-for-all-firmware-installs-and-updates) | ||
| - [Steps for bootloader + firmware installs via hardware debugger](#steps-for-bootloader--firmware-installs-via-hardware-debugger) | ||
| - [Steps for firmware updates via USB port](#steps-for-firmware-updates-via-usb-port) | ||
| - [Installing client](#installing-client) | ||
| - [Dependencies](#dependencies) | ||
| - [Installation](#installation) | ||
| - [Installation with pip](#installation-with-pip) | ||
| - [Using rfcat](#using-rfcat) | ||
| - [External Projects](#external-projects) | ||
| - [Epilogue](#epilogue) | ||
|
|
There was a problem hiding this comment.
i like the improved TOC.
i'd like to incorporate PandwaRF into the official RfCat core, which means that i'd like to include it in the "legacy" docs, if that works for you.
would you be willing to migrate the information into the "Legacy" README?
- add the PandwaRF and Rogue into the Supported Dongles section
- insert Docker information alongside the standard Python install (docker's a nice touch, btw!)
- touch up any other sections you've improved upon in the top section
thanks!
| print("PandwaRF (non Rogue) Detected") | ||
| return PandwaRF | ||
|
|
||
| print("Dongle is not a PandwaRF") |
There was a problem hiding this comment.
| print("Dongle is not a PandwaRF") | |
| print("Dongle is not a supported RfCat dongle") |
|
@trollwookiee @CharlieBailly i'm so sorry to make you wait. i apparently left my review open, so you never received the feedback. let's make this happen. assuming you're still interested. |
|
@atlas0fd00m @CharlieBailly Yes I would love to have PandwaRF support merged and have a single repo for RfCat !!! |
3 participants
No description provided.