Skip to content

Conversation

@dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Oct 14, 2022

I got the code to work, awesome! 🙂

Here's the Linux example ported from espresso to es-at-nal. It took me a while to figure out how to set up atat to work together with esp-at-nal, an example like this one would have helped me a lot.

Working example:

image

@dbrgn dbrgn force-pushed the linux-example branch 3 times, most recently from dee3a01 to cf24d97 Compare October 20, 2022 20:24
Copy link
Member

@marius-meissner marius-meissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to add a complete and real example! Maybe I will add an embedded example (e.g. for RP2040) when I get the chance in the future.

In general, the added docs + code looks good to me. Just a brief discussion regarding the dependencies maybe.

@marius-meissner
Copy link
Member

Please fix the code style and then the PR is ready to be merged.

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 24, 2022

Rebased and applied cargo fmt!

@marius-meissner
Copy link
Member

LGTM

@marius-meissner marius-meissner merged commit fc63b4d into atlas-aero:main Oct 24, 2022
@dbrgn dbrgn deleted the linux-example branch October 24, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants