APP-4737 Enhance MDIR with data domains and products #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanmanishd
changed the title
cmgrote
requested changes
Jan 21, 2025
| @@ -81,6 +81,24 @@ uiConfig { | |||
| helpText = "Whether to include detailed results (Yes), or only the headline metrics (No) in the Excel file produced." | |||
| fallback = false | |||
| } | |||
| ["include_data_products"] = new Radio { | |||
| title = "Include data products" | |||
There was a problem hiding this comment.
This should be something more like "Generate data products?" — at the moment it sounds like it's asking whether data products should be included in the report output (i.e. whether they should themselves be counted as assets).
(See the title and description of include_glossary, which this is basically replacing.)
Comment on lines
14
to
15
| @JsonProperty("include_glossary") val includeGlossary: String = "TRUE", | ||
| @JsonProperty("glossary_name") val glossaryName: String = "Metadata metrics", |
There was a problem hiding this comment.
These two include_glossary and glossary_name should be removed from the package.pkl file, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: APP-4737