-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FT-463 : Integrate golangci-lint
for Linting
#80
Conversation
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
…ash instead of version Signed-off-by: Karanjot Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Just a few questions:
- From looking into the config, it seems like it handles a lot of tasks, such as formatting, fixing imports, static checks, etc. I want to confirm: when someone pushes code, does it automatically fix those issues and create a new commit OR does it just highlight specific lines with issues through review comment?
- I think we should also document how to run this linter locally in the
README.md
. - If we can run this locally, we should also integrate it into
pre-commit
to save CI time (other enhancement req). This way, the linter violations are caught during the pre-commit step before they make it to the CI pipeline ✅
When someone runs the linter locally using
I plan to update the README and add the Contributing guidelines, badges etc. in the next PR. I thought it would be better to handle all the documentation updates in one PR to save time and make the review process easier.
Thanks for the suggestion! I forgot about it, but I’ll make sure to include it. |
Signed-off-by: Karanjot Singh <[email protected]>
Signed-off-by: Karanjot Singh <[email protected]>
Description
This PR integrates
golangci-lint
for linting Go code, using tools like govet, gosimple, and staticcheck etc. (seeconfig/.golangci.yaml
). It also sets up a GitHub Actions workflow to run the linter on code pushes and pull requests.Related Issue
FT-463
Checklist
Further Comments