fix: time based state refresh for each activity #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagrawal-atlan
requested review from
AtMrun,
firecast and
inishchith
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where stale connection data was persisting across successive workflow runs in crossover 2.0. The fix ensures that state is properly cleaned before each activity execution.
Key Changes:
- Modified state management in
_get_stateto unconditionally clean state before setting new state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.5%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/activity-state-fix |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/796 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Bug: State Management Typo Causes Caching FailuresThe state management logic has two issues. A typo ( |
abhishekagrawal-atlan
changed the title
Bug: Timestamp Update Missing in Base ClassMissing timestamp update in base class |
Bug: Timestamp Handling Fails for Initial StatesThe timestamp refresh logic can fail if |
inishchith
reviewed
Oct 31, 2025
Member
|
@abhishekagrawal-atlan - has this been tested on production instances? is this ready to merge? |
📦 Example workflows test results
|
📦 Example workflows test results
|
📦 Example workflows test results
|
Collaborator
Author
This has been tested on internal instances - https://apps-framework-redshift-testing.atlan.com/. will create a ring of some production instances to test it out. |
| # Update timestamp only after successful client creation and assignment | ||
| # This ensures that if initialization fails, the old timestamp remains | ||
| # and the state can be refreshed again immediately | ||
| self._state[workflow_id].last_updated_timestamp = datetime.now() |
There was a problem hiding this comment.
Bug: Partial state initialization prevents automatic state refresh
The refactored _set_state method creates the state object and sets workflow_args (lines 170-177) before initializing the SQL client. If client initialization fails (lines 186-193), last_updated_timestamp is never set (line 217 not reached). On subsequent calls to _get_state, the base class check if last_updated and ... evaluates to False when last_updated is None, so it returns the broken state without attempting re-initialization. The old code called super()._set_state() first, which set last_updated_timestamp before client creation could fail, allowing time-based refresh to eventually recover. The fix could be to set last_updated_timestamp earlier, or add a check for incomplete state (e.g., sql_client is None).
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Checklist
Copyleft License Compliance
Note
Adds a 15‑minute time-based state refresh for activities and safely reinitializes SQL clients with credential loading and graceful client swap.
last_updated_timestamptoActivitiesStateand update in_set_state._get_state.last_updated_timestamp._set_stateto create/load a new SQL client (load credentials first), then close old client, assign new client/handler, and update timestamp only on success.workflow_argsduring refresh; add debug/warning logs on client close.opentelemetry-exporter-otlpto1.38.0inpyproject.toml.Written by Cursor Bugbot for commit c91d6e4. This will update automatically on new commits. Configure here.