Skip to content

fix: windows path separator issue in sdk #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junaidrahim wants to merge 3 commits into from
Closed

fix: windows path separator issue in sdk #795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a6a88e
Refactor: Use pathlib for cross-platform path handling
cursoragent Oct 22, 2025
936b075
Merge branch 'main' into cursor/fix-windows-path-separator-issue-in-s…
inishchith Dec 9, 2025
99cade0
Merge branch 'main' into cursor/fix-windows-path-separator-issue-in-s…
inishchith Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion application_sdk/services/objectstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import json
import os
import shutil
from pathlib import Path
from typing import List, Union

import orjson
Expand Down Expand Up @@ -422,14 +423,18 @@ async def download_prefix(
store_name: Name of the Dapr object store binding to use.
"""
try:
# Convert destination to Path object for cross-platform compatibility
dest_path = Path(destination)

# List all files under the prefix
file_list = await cls.list_files(source, store_name)

logger.info(f"Found {len(file_list)} files to download from: {source}")

# Download each file
for file_path in file_list:
local_file_path = os.path.join(destination, file_path)
# Use Path for proper OS-independent path joining
local_file_path = str(dest_path / file_path)
Copy link

@cursor cursor bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Pathlib normalization breaks current directory file downloads

The migration from os.path.join to pathlib.Path introduces a behavioral regression. When destination is "." (current directory) and file_path is a filename-only string (returned by list_files when prefix isn't found in path), Path(".") / "file.txt" normalizes to just "file.txt" whereas os.path.join(".", "file.txt") preserved the "./" prefix. This causes download_file to call os.makedirs("") which raises FileNotFoundError, since os.path.dirname("file.txt") returns an empty string instead of ".".

Fix in Cursor Fix in Web

await cls.download_file(file_path, local_file_path, store_name)

logger.info(f"Successfully downloaded all files from: {source}")
Expand Down
Loading