Skip to content

fix: issue with path is returned from download_files is always set t… #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

fix: issue with path is returned from download_files is always set t… #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions application_sdk/inputs/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,10 @@ async def get_dataframe(self) -> "pd.DataFrame":
try:
import pandas as pd

path = self.path
if self.input_prefix and self.path:
path = await self.download_files(self.path)
await self.download_files(self.path)
# Use pandas native read_parquet which can handle both single files and directories
return pd.read_parquet(path)
return pd.read_parquet(self.path)
Comment on lines +93 to +95
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix assumes that download_files modifies self.path in-place, but this behavior is not evident from the code shown. If download_files doesn't update self.path to point to the downloaded local file, this will still read from the original remote path. Consider either ensuring download_files updates self.path or capturing its return value if it returns the local path.

Copilot uses AI. Check for mistakes.

Comment on lines 92 to +95
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix assumes that download_files modifies self.path in-place, but this behavior is not evident from the code shown. If download_files doesn't update self.path to point to the downloaded local file, this will still read from the original remote path. Consider either ensuring download_files updates self.path or capturing its return value if it returns the local path.

Copilot uses AI. Check for mistakes.

except Exception as e:
logger.error(f"Error reading data from parquet file(s): {str(e)}")
# Re-raise to match IcebergInput behavior
Expand Down