Tool: Create Data Domains/Sub Domains/Products #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firecast
requested changes
Nov 28, 2025
| ) | ||
| else: | ||
| logger.debug(f"Creating DataDomain: {spec.name}") | ||
| domain = DataDomain.creator(name=spec.name) |
Member
There was a problem hiding this comment.
Can't we just pass None if it doesn't exist and remove this if condition?
|
|
||
| domain.user_description = spec.user_description | ||
|
|
||
| if spec.certificate_status: |
| assets: List[DataProduct] = [] | ||
| for spec in specs: | ||
| # Validate that asset_guids is provided and not empty | ||
| if not spec.asset_guids: |
Member
There was a problem hiding this comment.
Lets add these validations as part of the DataProductSpec pydantic model
| logger.debug(f"Linking {len(spec.asset_guids)} asset(s) to product") | ||
|
|
||
| # Build FluentSearch to select assets by their GUIDs | ||
| asset_selection = ( |
Member
There was a problem hiding this comment.
Do we need the complete asset list to create the data product?
| ) | ||
| product.user_description = spec.user_description | ||
|
|
||
| if spec.certificate_status: |
| return save_assets(assets) | ||
|
|
||
|
|
||
| def create_domain_assets( |
Member
There was a problem hiding this comment.
Why not just create 2 different tools?
| logger.error(f"Error saving assets: {e}") | ||
| raise | ||
|
|
||
| created_assets = response.mutated_entities.CREATE |
Member
There was a problem hiding this comment.
Lets also return updated assets. If we are making this function lets use it elsewhere as well where we are directly saving
|
|
||
|
|
||
| @mcp.tool() | ||
| def create_domains(items) -> List[Dict[str, Any]]: |
Member
There was a problem hiding this comment.
Lets create 2 tools, one for domains and one for products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for creating Data Domains, Sub Domains, and Data Products in Atlan via a new unified tool and supporting backend logic. The changes introduce new models, backend asset creation logic, and expose the new functionality through the server and tool initialization files.
New functionality for domain-related asset creation:
create_domainsto the server, allowing creation of Data Domains, Sub Domains, and Data Products with a unified interface that auto-detects the type based on the input fields. The tool includes comprehensive documentation and examples.create_domain_assetsin the tool initialization and server, making it available for use. [1] [2] [3]Backend implementation and models:
modelcontextprotocol/tools/domain.py, which provides functions to create Data Domains, Sub Domains, and Data Products, including input parsing, model instantiation, and bulk asset saving with logging and error handling.DataDomainSpec,DataSubDomainSpec,DataProductSpec) to validate and structure payloads for the new asset types.