Skip to content

Conversation

bladata1990
Copy link
Collaborator

This PR adds support for updating classifications to the update_asset_tool.
The tool was tested with claude integrated locally and is able to add tags to an asset. This PR does not remove any tags on the asset

@@ -1,5 +1,5 @@
version = 1
revision = 2
revision = 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the fastmcp dependency, we dont need mcp[cli]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check the pre-commit checks failing in the CI.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the changes added to this file, as we no longer using mcp[cli]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to main branch, a bracket seems to be on a different line

author Bala <[email protected]> 1757908811 +0530
committer Bala <[email protected]> 1758000441 +0530

Add support to update_Assets_tool with update classifications

update Args instructions

remove unused imports

updated review comments

Reverted all changes to uv lock
Copy link
Member

@firecast firecast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to first add a tool to fetch classifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants