Skip to content

Improve xterm scrollbar styling and container height #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SnaetWarre merged 1 commit into from
Aug 3, 2025
Merged

Improve xterm scrollbar styling and container height #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/terminal/terminal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
position: relative;
overflow: hidden;
padding-left: 16px; /* Only add left padding */
padding-right: 8px;
}

/* Ensure xterm doesn't overflow its container */
Expand Down Expand Up @@ -31,9 +30,7 @@
}

.xterm-container .xterm-viewport::-webkit-scrollbar-track {
background-color: var(--color-hover);
border-radius: 6px;
margin: 4px;
border-left: 1px solid var(--color-border);
}

.xterm-container .xterm-viewport::-webkit-scrollbar-thumb {
Expand Down Expand Up @@ -74,4 +71,4 @@
/* Override xterm cursor when hovering links */
.xterm.xterm-cursor-pointer {
cursor: pointer !important;
}
}
2 changes: 1 addition & 1 deletion src/components/terminal/terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ export const XtermTerminal: React.FC<XtermTerminalProps> = ({
id={`terminal-${sessionId}`}
className={cn("xterm-container", "w-full", "text-text", !isActive && "opacity-60")}
style={{
height: "calc(100% - 40px)", // Subtract footer height to prevent content going below
height: "calc(100% - 1px)", // Subtract footer height to prevent content going below
}}
/>
</div>
Expand Down
Loading