always reset raw value when tag value is set, initialize tag values

aternosorg · Mar 4, 2022 · 83e59f4 · 83e59f4
1 parent 5cfc1a4
commit 83e59f4
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 15 deletions.
diff --git a/src/Tag/DoubleTag.php b/src/Tag/DoubleTag.php
@@ -31,9 +31,7 @@ public function generatePayload(NbtSerializer $serializer): string
      */
     public function setValue(float $value): FloatValueTag
     {
-        if($value !== $this->value) {
-            $this->resetRawValue();
-        }
+        $this->resetRawValue();
         return parent::setValue($value);
     }
 
@@ -48,4 +46,4 @@ protected function readPayload(Reader $reader): Tag
         $this->value = $reader->getSerializer()->decodeDouble($this->rawValue);
         return $this;
     }
-}
+}
diff --git a/src/Tag/FloatTag.php b/src/Tag/FloatTag.php
@@ -29,9 +29,7 @@ public function generatePayload(NbtSerializer $serializer): string
      */
     public function setValue(float $value): FloatValueTag
     {
-        if($value !== $this->value) {
-            $this->resetRawValue();
-        }
+        $this->resetRawValue();
         return parent::setValue($value);
     }
 
@@ -46,4 +44,4 @@ protected function readPayload(Reader $reader): Tag
         $this->value = $reader->getSerializer()->decodeFloat($this->rawValue);
         return $this;
     }
-}
+}
diff --git a/src/Tag/FloatValueTag.php b/src/Tag/FloatValueTag.php
@@ -4,7 +4,7 @@
 
 abstract class FloatValueTag extends Tag
 {
-    protected float $value;
+    protected float $value = 0;
 
     /**
      * @return float

diff --git a/src/Tag/IntValueTag.php b/src/Tag/IntValueTag.php
@@ -4,7 +4,7 @@
 
 abstract class IntValueTag extends Tag
 {
-    protected int $value;
+    protected int $value = 0;
 
     /**
      * @return int

diff --git a/src/Tag/LongTag.php b/src/Tag/LongTag.php
@@ -30,9 +30,7 @@ public function generatePayload(NbtSerializer $serializer): string
      */
     public function setValue(int $value): IntValueTag
     {
-        if($value !== $this->value) {
-            $this->resetRawValue();
-        }
+        $this->resetRawValue();
         return parent::setValue($value);
     }
 
@@ -47,4 +45,4 @@ protected function readPayload(Reader $reader): Tag
         $this->value = $result->getValue();
         return $this;
     }
-}
+}
diff --git a/src/Tag/StringTag.php b/src/Tag/StringTag.php
@@ -10,7 +10,7 @@ class StringTag extends Tag
 {
     public const TYPE = TagType::TAG_String;
 
-    protected string $value;
+    protected string $value = "";
 
     /**
      * @return string