don't accept stings longer than 0xffff

aternosorg · Sep 10, 2021 · 6d8123e · 6d8123e
1 parent c0cffc1
commit 6d8123e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Tag/StringTag.php b/src/Tag/StringTag.php
@@ -39,10 +39,15 @@ public function getLength(): int
 
     /**
      * @inheritDoc
+     * @throws \Exception
      */
     public function generatePayload(NbtSerializer $serializer): string
     {
-        return $serializer->encodeStringLengthPrefix(strlen($this->value)) . $this->value;
+        $length = strlen($this->value);
+        if($length > 0xffff) {
+            throw new \Exception("String exceeds maximum length of " . 0xffff . " characters");
+        }
+        return $serializer->encodeStringLengthPrefix($length) . $this->value;
     }
 
     /**