Repository navigation
Fix Redis driver treating every query as failed - #58
Merged
Merged
Conversation
JulianVennen
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #34 (v5.0.0),
RedisQueryException::checkConnection()throws unlessRedis::getLastError()returnsfalse. But phpredis returnsnullwhen there is no error (checked 5.3.7, 6.0.0 and 6.3.0), andfalseonly when there is no connection at all. So everysave(),get()anddelete()of a model with a cache time throws an emptyRedisQueryException: Redis Query Error:, which makes the Redis cache unusable.Changes
checkConnection()only throws ifgetLastError()returns a string, and clears the error before throwing. phpredis keeps the last error untilclearLastError()is called, so it would otherwise be reported again for every later query.save(),get()anddelete()clear the last error before running their command, so an error left by another command on the same connection (e.g. when the connection is shared with other code) isn't reported as a model error.RedisQueryExceptionTest(uses a\Redisstub, requiresext-redis) and enable the redis extension in the test workflow so it runs in CI.Testing
WRONGTYPE) is still thrown, and the next query works normally afterwards.Models without a cache time are not affected, since the driver returns before connecting.