added bind options for both service port and metrics port for spacedsust, slingshot, and ufos

[jvalinsky]

The clippy linting has a rule for too_many_arguments set to a max of 7, my refactored serve func for slingshot has 8 args:

pub async fn serve(
    cache: HybridCache<String, CachedRecord>,
    identity: Identity,
    repo: Repo,
    domain: Option<String>,
    acme_contact: Option<String>,
    certs: Option<PathBuf>,
    shutdown: CancellationToken,
    bind: std::net::SocketAddr,
) -> Result<(), ServerError> {

How do you recommend fixing this?

[uniphil]

yessss. i love when fixing hacks actually makes code simpler and safer

[uniphil]

@jvalinsky thank you!!!!

to fix that clippy report you can throw one of these on it

#[allow(clippy::too_many_arguments)]
pub async fn serve(
    cache: HybridCache<String, CachedRecord>,
    ...

eventually it should be refactored to take a config struct or something, but i don't want to spend time on that now because i kind of want to refactor some of the top-level app-running boilerplate into some helpers across the whole repo, which would probably account for that. silencing clippy here is fine :)

---

a few more fmt things are going to bite you before this passes, but that's the easy part. if you run make check in the project root it should automatically apply most or all of them, and if that doesn't work easily i'm happy to do a quick fixup before merging!

[uniphil]

does doing just TcpListener::bind(bind) (without .to_string()) work here?

[uniphil]

clippy is probably yelling at you for not doing

log::info!("metrics server installed! listening on http://{bind_metrics}");

here

[uniphil]

...and here

[uniphil]

couple small nits but this is the exact right approach :)